Repository navigation
own: lazy fills through @nodrops C calls, stores then used, a let given fresh values on some paths (TSLANG 63-66) - #854
Merged
Merged
Conversation
… a local or element store then used (TSLANG 63-65) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ws them from a slot of their own (TSLANG 66) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e still cannot be assigned (TSLANG 66 splits the rest) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
DefaultLib |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More gaps found by compiling powder_sandbox's native_ts_graphics under
-mm=own(TSLANG_ISSUES 63-66).@nodropsC call (core/nri.ts'scachedVertexBuffergetters). A C declaration with no export, import or dllimport, not variadic, and given and returning only numbers, strings, null/undefined or@cpphandles, runs nothing of the module, so the fill (TSLANG 47) holds across it.simple_pbr_nri.ts). This includes anewin one arm of a?:.logic_op_dynamic_state_nri.ts). It borrows the element or field from the store on, as TSLANG 50 does.letborrowing a field, then given a fresh value on some paths (core/donut_first_person_camera.ts'sanimate). After a failed dry run, each fresh value goes into a slot of its own, released where theletis, and theletborrows it. Escapes, a field overwritten before the use, and loops are checked like any other borrow.own_err_field_let_assignednow uses a shape that is still refused (theletchanged in place through its slot); its old shape compiles and runs correctly.Sweep of the 276 ntg sources: 807 → 664 errors and 119 → 118 failing, with no source getting more errors. The camera module now compiles, and with its facts so do the calls into it.
Tests:
00tslang_issue_63.tsand00tslang_issue_66.ts(every model), plusown_err_local_stored_element_reset,own_err_pushed_object_field_popped,own_err_split_let_storedandown_err_split_let_field_overwritten.Validation: full ctest (Release) passed 7303/7304; the one failure was the outdated
own_err_field_let_assignedexpectation, which is fixed here and passes. DefaultLibtests.ps1passes on all four models (see comment).🤖 Generated with Claude Code